Skip to content

Conversation

@ash-t-luu
Copy link
Contributor

Overview

Issue Type

  • Bug
  • Feature
  • Tech Debt

Description
Added conditionals for checking directives such as 'use client' to determine the component type.
Added 'npx tsc ; -path to test build-' in package.json

Ticket Item
RL-36: Create conditional for 'use client'/'use server' in parser

Steps to Validate Feature

  1. Run npm run webpack
  2. Run extension test
  3. Pass in the file with 'use client' directive or without
  4. See accurate changes in component typing

Previous behavior
Before we had a conditional on rendering component type based on the use of hooks.

Expected behavior
Now we have conditional on rendering component type based on use of directives and hooks.

…mments to make it uniform, moved getNonce into a util folder, changed property in .eslintrc.json to remove non-dangerous warnings when running tests
Copy link
Contributor

@Louka3 Louka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@Ponch49 Ponch49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Ponch49 Ponch49 merged commit 5696f60 into dev Jan 27, 2024
@ash-t-luu ash-t-luu deleted the AL/directives branch February 15, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants