Skip to content

added favicon of logo to webview #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023
Merged

added favicon of logo to webview #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added media/favicon.ico
View file
Open in desktop
Binary file not shown.
8 changes: 7 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@
"name": "Test"
}
]
}
},
"viewsWelcome": [
{
"view": "metrics-file",
"contents": "View tree to see where improvements can be made!\n[View Tree](command:myExtension.showPanel)\n"
}
]
},
"scripts": {
"lint": "eslint .",
Expand Down
6 changes: 4 additions & 2 deletions src/panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,18 @@ function createPanel(context) {
// create one new tab
vscode.ViewColumn.One,
{
enableScripts: true
enableScripts: true,
retainContextWhenHidden: true
}
);

panel.iconPath = vscode.Uri.joinPath(context.extensionUri, 'media', 'favicon.ico');

const bundlePath = vscode.Uri.joinPath(context.extensionUri, 'build', 'bundle.js');

// set webview URI to pass into html script
const bundleURI = panel.webview.asWebviewUri(bundlePath);


// render html of webview here
panel.webview.html = createWebviewHTML(bundleURI);
}
Expand Down