Revised PR to publish PROMCODE machine readable files#306
Revised PR to publish PROMCODE machine readable files#306tomkamimura wants to merge 11 commits intooslc-op:masterfrom
Conversation
|
Thank you @tomkamimura. May I ask if you ran ShapeChecker and if it produced any output? What flags did you use so that I can reproduce? |
|
CC @jamsden so that he gets notifications for this PR. |
|
ShapeCheck report: Report |
|
@tomkamimura thank you for the PR. All looks good from my side with the validity of the RDF, please see comments about the metadata inside. @jamsden I think we can go ahead with the PR. ShapeChecker produces warnings on multiline strings, but those are not errors. Errors are raised on http://purl.org/dc/terms/, which is the correct namespace but does not provide RDF via conneg. @ndjc Nick, if you could refresh my memory on how we dealt with incorrect dcterms namespace redirects, I would be very thankful! |
| dcterms:source <https://tools.oasis-open.org/version-control/browse/wsvn/oslc-promcode/shape/trunk/promcode-vocab.ttl> ; | ||
| dcterms:hasVersion "CS02" ; | ||
| dcterms:issued "2021-03-23"^^<http://www.w3.org/2001/XMLSchema#date> ; | ||
| dcterms:isPartOf <https://tools.oasis-open.org/version-control/browse/wsvn/oslc-promcode/shape/trunk/spec.html> ; |
There was a problem hiding this comment.
There was a problem hiding this comment.
I will fix it, cancel this PR and create a new PR with revised files.
There was a problem hiding this comment.
Tom, no need for a new PR. Just push the fix commit to the same branch.
| dcterms:publisher <https://open-services.net/about/> ; | ||
| dcterms:source <https://tools.oasis-open.org/version-control/browse/wsvn/oslc-promcode/shape/trunk/promcode-vocab.ttl> ; | ||
| dcterms:hasVersion "CS02" ; | ||
| dcterms:issued "2021-03-23"^^<http://www.w3.org/2001/XMLSchema#date> ; |
There was a problem hiding this comment.
Should it be 2021-11-10? It says so on https://docs.oasis-open.org/oslc-promcode/promcode/v1.0/cs02/promcode-spec.html
There was a problem hiding this comment.
I will fix it, cancel this PR and create a new PR with revised files.
| @@ -0,0 +1,397 @@ | |||
| # OSLC PROMCODE Version 1.0 | |||
| # Committee Specification Draft | |||
| # 2 November 2021 | |||
There was a problem hiding this comment.
I think this text above copyright can be removed to avoid confusion. Otherwise, please make sure it matches the Ontology resource contents.
There was a problem hiding this comment.
I will fix it, cancel this PR and create a new PR with revised files.
| rdfs:label "OSLC PROMCODE Constraints" ; | ||
| dcterms:description "All vocabulary URIs defined in the OSLC PROMCODE namespace."^^rdf:XMLLiteral ; | ||
| dcterms:publisher <https://open-services.net/about/> ; | ||
| dcterms:issued "2021-03-23"^^<http://www.w3.org/2001/XMLSchema#date> ; |
There was a problem hiding this comment.
I will fix it, cancel this PR and create a new PR with revised files.
| dcterms:issued "2021-03-23"^^<http://www.w3.org/2001/XMLSchema#date> ; | ||
| dcterms:license <http://www.apache.org/licenses/LICENSE-2.0> ; | ||
| dcterms:source <https://tools.oasis-open.org/version-control/browse/wsvn/oslc-promcode/shape/trunk/promcode-shapes.ttl> ; | ||
| dcterms:isPartOf <https://tools.oasis-open.org/version-control/browse/wsvn/oslc-promcode/shape/trunk/spec.html> ; |
There was a problem hiding this comment.
There was a problem hiding this comment.
I will fix it, cancel this PR and create a new PR with revised files.
| @@ -0,0 +1,1068 @@ | |||
| # OSLC PROMCODE Version 1.0 | |||
| # Committee Specification Draft | |||
| # 2 November 2021 | |||
There was a problem hiding this comment.
I will fix it, cancel this PR and create a new PR with revised files.
|
I will update promcode-shapes.ttl and promocode-vocab.ttl and will create a new PR. |
The stage of each file has been corrected.