Fix memory errors #175
Merged
Fix memory errors #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After osm2pgsql-dev@d1b6c5e#diff-a4a10b448709d2cc5dc0c85fb36a2b1c the RAM cache size can be zero, but ``am_cache_nodes_set_sparse`` often accesses ``sparseBlock[0]``. It gives serious memory access erros and failures during testing (detected with Intel Inspector XE when fixing Windows builds osm2pgsql-dev#17 ). I am not sure the proposed fix is the best solution, but something should be done with this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After d1b6c5e#diff-a4a10b448709d2cc5dc0c85fb36a2b1c
the RAM cache size can be zero, but
ram_cache_nodes_set_sparsefunction often accessessparseBlock[0]. It gives serious memory access errors and failures during testing (detected with Intel Inspector XE when fixing Windows builds #17 ).I am not sure the proposed fix is the best solution, but something should be done with this error.