Remove copy_thread parameter from output constructors #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output derived classes can create the copy_thread themselves. They just need the options which they have anyway.
joto
force-pushed
the
remove-copy-thread-param
branch
from
615addf to
47abd1d
Compare
lonvia
reviewed
Nov 30, 2022
src/output-gazetteer.hpp
Outdated
| : output_t(mid, std::move(thread_pool), options), m_copy(copy_thread), | ||
| options_t const &options) | ||
| : output_t(mid, std::move(thread_pool), options), | ||
| m_copy(std::make_shared<db_copy_thread_t>(get_options()->conninfo)), |
Collaborator
There was a problem hiding this comment.
Just use options.conninfo here to be consistent with m_proj initialisation below?
Dito above in output-flex.cpp.
Collaborator
Author
There was a problem hiding this comment.
I have added a commit fixing this (and also changing the parameter name o to options in some places for consistency, and short names are bad anyway).
Does the same thing, but first is simpler. Also renames parameter name "o" to "options".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output derived classes can create the copy_thread themselves. They just need the options which they have anyway.