Make the display of time intervals show seconds. #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Jun 26, 2023
scripts/osm2pgsql-replication
Outdated
| if hours > 0 or days > 0 or weeks > 0: | ||
| output.append("{} hour(s)".format(hours)) | ||
|
|
||
| output.append("{} minute(s)".format(minutes)) |
Collaborator
There was a problem hiding this comment.
This should now be conditional as well.
Rather than rounding down to nearest minute.
amandasaurus
force-pushed
the
time-no-longer-approximate
branch
from
8acbb62 to
c3fbb1e
Compare
Contributor
Author
|
Changes made & new version force pushed (after rebase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people would rather have non-approximate times (e.g.). This patch makes the times always show seconds.
I don't have a strong preference. I am OK with this patch being accepted or not.