fix printf formats for 64 bit values #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Incorrect. Fixing :) |
alex85k
force-pushed
the
fix-printf
branch
3 times, most recently
from
c48166a to
6c6f28c
Compare
Contributor
Author
|
Strange. Travis does not build it at all... |
alex85k
force-pushed
the
fix-printf
branch
3 times, most recently
from
9fc3a2e to
6813dda
Compare
Contributor
Author
|
Seems to pass checks now. Also enabled -Werror on MacOS (Travis only) |
Collaborator
|
boost::format has bad performance (#398) but all these fprintfs are only run once. I'd be okay with changing these to boost::format, which I believe would avoid the formatting string issues completely. We still need to find a logging library (#202), but just printing to stderr like before is good enough for now. |
This was referenced Oct 30, 2015
Collaborator
|
Merging, and I'll look at doing a backport for 0.88.x. Pulling out fprintf can wait. |
pnorman
added a commit
that referenced
this pull request
Oct 30, 2015
fix printf formats for 64 bit values
|
Changes Unknown when pulling 6813dda on alex85k:fix-printf into ** on openstreetmap:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix #468 . Is this correct?