Skip to content

Search favorites or tracks by name#1683

Merged
alisa911 merged 45 commits into
mainfrom
search-fav-or-track
May 21, 2026
Merged

Search favorites or tracks by name#1683
alisa911 merged 45 commits into
mainfrom
search-fav-or-track

Conversation

@Dima-1
Copy link
Copy Markdown
Contributor

@Dima-1 Dima-1 commented May 1, 2026

Comment thread map/src/manager/track/DeleteTrackManager.js Outdated
Comment thread map/src/manager/track/TracksManager.js Outdated
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/public/images/map_icons/ic_action_polygon_dark.svg
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/infoblock/components/InformationBlock.jsx Outdated
Comment thread map/src/manager/track/DeleteTrackManager.js Outdated
@Dima-1 Dima-1 marked this pull request as ready for review May 12, 2026 20:07
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread tests/selenium/src/tests/search/36-search-track-and-favorite.mjs
Comment thread map/src/infoblock/components/InformationBlock.jsx Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/manager/FavoritesManager.js Outdated
@alisa911
Copy link
Copy Markdown
Contributor

alisa911 commented May 13, 2026

  • After refreshing the page map/search/result/?query=Test#13/50.4613/30.5351 tracks and favorites disappear from the results cff1341
  • After opening the track and closing it, the track menu flashes for a second before opening the search results. The bug should be a back arrow, not a cross, and there shouldn't be any flashing.
  • The favorite should also have a back arrow, not a cross, and there should be no blinking.
  • The state is broken. If you click on a favorite in the search and then on a favorite on the map, after closing the last one, the previous one should open with a back arrow that leads to the search results.9511dc5
  • When you select a track from the search results, the track menu is highlighted in the left menu, but the search should remain
  • Tracks and favorites should be stored in the search menu state, just like poi, and be removed upon return if they were opened.

Comment thread map/src/map/util/Clusterizer.js Outdated
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/menu/search/search/SearchResultItem.jsx Outdated
Comment thread map/src/manager/FavoritesManager.js
Comment thread map/src/manager/FavoritesManager.js Outdated
@Dima-1 Dima-1 requested a review from alisa911 May 19, 2026 08:30
Copy link
Copy Markdown
Contributor

@alisa911 alisa911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - When clicking on a track from the search, its URL is now broken, and it's duplicated and opens in the track menu.
2 - The same thing happens with the favorite URL, which is broken.

Fix 061216c

@alisa911
Copy link
Copy Markdown
Contributor

alisa911 commented May 19, 2026

Screenshot 2026-05-19 at 19 59 36

Fix b15d4b8

@alisa911
Copy link
Copy Markdown
Contributor

alisa911 commented May 19, 2026

Сlosed but not fixed
Screenshot 2026-05-19 at 20 28 06
Fix 982f19c

Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/map/layers/SearchLayer.js Outdated
Comment thread map/src/manager/FavoritesManager.js Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements searching within user data (cloud tracks and favorites) by name to address issue #1065, integrating user-object hits into the existing search results flow and ensuring selected items can be opened and navigated back from.

Changes:

  • Add client-side search hits for cloud tracks and favorites, merging them into the existing search results list.
  • Update menu/infoblock navigation to support opening items from search and returning to search results.
  • Add an end-to-end Selenium test covering search + open + delete flows for both tracks and favorites.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/selenium/src/tests/search/36-search-track-and-favorite.mjs Adds E2E coverage for searching/opening/removing tracks and favorites by name.
map/src/util/hooks/menu/useMenuDots.js Includes selectedSearchObj when determining active menu context.
map/src/menu/tracks/CloudTrackItem.jsx Refactors track info text formatting into a reusable helper.
map/src/menu/search/search/SearchResults.jsx Adjusts search triggering and passes current location into items.
map/src/menu/search/search/SearchResultItem.jsx Adds rendering/handling for GPX_TRACK and FAVORITE search hits.
map/src/menu/MainMenu.js Adds support for opening “search-selected” objects and returning to results.
map/src/menu/favorite/FavoriteItem.jsx Adds onOpen/hideActions/id to reuse FavoriteItem in search results.
map/src/menu/actions/HeaderHelper.js Clears search selection state when closing a favorite opened from search.
map/src/map/util/MapManager.js Registers an icon mapping for GPX track search hits.
map/src/map/layers/SearchLayer.js Merges local favorites + track hits into search results and avoids map markers for them.
map/src/map/layers/FavoriteLayer.js Keeps favorites visible when they appear in search results (incl. hidden groups).
map/src/manager/track/TracksManager.js Prevents “opened from search” tracks from being saved as menu selection.
map/src/manager/SearchManager.js Adds feature builders for searching favorites and cloud tracks; adds back-navigation helper.
map/src/manager/FavoritesManager.js Refactors favorite open/select helpers and adds “open from search” entry point.
map/src/infoblock/components/wpt/WptDetails.jsx Updates favorite close behavior to support returning to search results.
map/src/infoblock/components/InformationBlock.jsx Adds back-navigation to search results when closing a track opened from search.
map/src/infoblock/components/favorite/WptEditPanel.jsx Updates favorite opening to new openFavoriteObj signature.
map/src/context/AppContext.js Adds searchCollator, selectedSearchObj, and searchFavoriteGroupIds state.
map/public/images/map_icons/ic_action_polygon_dark.svg Adds new SVG used for GPX track search icon.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread map/src/manager/SearchManager.js
Comment thread map/src/map/layers/FavoriteLayer.js
Comment thread map/src/menu/search/search/SearchResultItem.jsx
Comment thread map/src/infoblock/components/wpt/WptDetails.jsx
@alisa911 alisa911 merged commit 2450520 into main May 21, 2026
@alisa911 alisa911 deleted the search-fav-or-track branch May 21, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants