Simplify handling of custom request parameters #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookies can now be handed in as an extra parameter for the requests library.
Using a function instead of a parameter in __init__ is easier to handle and makes it simple to detect if the new functionality is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requests library seems to ignore socket timeouts with the result that newer versions of the pyosmium tools may hang again on a bad network connection. There is no global parameter to set timeouts in requests, so the whole code needs to be rearranged a bit.
ReplicationServernow has an extra functionset_request_parameter()with which extra parameters forrequests.get()can be set. This is not only used for timeouts but also to hand in the cookies.Overwriting the
open_url()function should no longer be necessary. You can set proxies, authentication, certificates etc. all with the new function.