Bump pnpm/action-setup from 5 to 6#1
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
Conversation
dependabot
Bot
added
dependencies
jimdou
added a commit
that referenced
this pull request
Apr 29, 2026
…ault + activity log no longer drowns in bus events Three connected bugs and one polish ask: 1. Phantom claims every 5s after a run finishes The scheduler treated 'review' status as runnable. After the executor finished a run and parked it in awaiting_review, the planner kept picking the SAME sub-task on every orchestrator tick. Each pick: - created a new claim (run-launcher.ts:112) - tried to create a worktree on a branch that already existed - threw — but the claim was already on disk, orphaning forever Fix: - scheduler.ts: new isAlreadyHandled() that filters status='running' and status='review'. The candidate filter combines this with the existing isTerminal() check. - run-launcher.ts: wrap ensureWorktree in try/catch. On failure we archiveClaim() the just-created claim and push a typed 'worktree_failed:<msg>' skip reason instead of leaking. Defense in depth: even if the scheduler missed a case, the claim no longer zombies. - One-time housekeeping: archived the 11 orphaned claims sitting in ~/Dev/test-backlog-demo/.backlog/claims/active/ from this bug. 2. Topbar Stop didn't switch back to Play Symptom of #1: every 5s a new claim was being made for a stuck sub-task, and the SSE stream kept the UI in 'something is happening' mode. With the planner no longer re-launching, hasInFlightRun correctly drops to false when the run hits awaiting_review and the topbar visual transitions Stop → Play, all-done toast fires. 3. Activity log flooded with naked 'claim.changed' lines Bus events (claim.changed / subtask.changed / task.changed / run.changed / orchestrator.changed) carry no payload — they're a hint to the BOARD that something changed, not user-visible activity. Removed the bus subscription from ActivityBanner; the activity SSE already surfaces every meaningful event with run_id + message (executor.start, agent.bash, run.committed, run.pushed, etc.). App.svelte still listens to /events for board-refresh purposes. 4. Worktree mode at top, default Direct CreateTaskDialog: the worktree-mode dropdown was buried under all the commit/push/PR toggles. Moved it to the top of the Execution fieldset (it's the single biggest decision per task) and switched the default from 'isolated_worktree' to 'direct'. The schema + task-service defaults follow. Note in the schema/UI is honest about the executor still using a worktree under the hood until 'direct' is wired downstream. Polish: 'Met en file la PR via gh pr merge --squash --auto' — indecipherable to a non-technical user. Replaced both languages with 'Squash-merge the PR as soon as it's green. If your branch has required CI checks or reviews, the merge waits for them.' 247/247 still pass.
jimdou
added a commit
that referenced
this pull request
Apr 30, 2026
…ault + activity log no longer drowns in bus events Three connected bugs and one polish ask: 1. Phantom claims every 5s after a run finishes The scheduler treated 'review' status as runnable. After the executor finished a run and parked it in awaiting_review, the planner kept picking the SAME sub-task on every orchestrator tick. Each pick: - created a new claim (run-launcher.ts:112) - tried to create a worktree on a branch that already existed - threw — but the claim was already on disk, orphaning forever Fix: - scheduler.ts: new isAlreadyHandled() that filters status='running' and status='review'. The candidate filter combines this with the existing isTerminal() check. - run-launcher.ts: wrap ensureWorktree in try/catch. On failure we archiveClaim() the just-created claim and push a typed 'worktree_failed:<msg>' skip reason instead of leaking. Defense in depth: even if the scheduler missed a case, the claim no longer zombies. - One-time housekeeping: archived the 11 orphaned claims sitting in ~/Dev/test-backlog-demo/.backlog/claims/active/ from this bug. 2. Topbar Stop didn't switch back to Play Symptom of #1: every 5s a new claim was being made for a stuck sub-task, and the SSE stream kept the UI in 'something is happening' mode. With the planner no longer re-launching, hasInFlightRun correctly drops to false when the run hits awaiting_review and the topbar visual transitions Stop → Play, all-done toast fires. 3. Activity log flooded with naked 'claim.changed' lines Bus events (claim.changed / subtask.changed / task.changed / run.changed / orchestrator.changed) carry no payload — they're a hint to the BOARD that something changed, not user-visible activity. Removed the bus subscription from ActivityBanner; the activity SSE already surfaces every meaningful event with run_id + message (executor.start, agent.bash, run.committed, run.pushed, etc.). App.svelte still listens to /events for board-refresh purposes. 4. Worktree mode at top, default Direct CreateTaskDialog: the worktree-mode dropdown was buried under all the commit/push/PR toggles. Moved it to the top of the Execution fieldset (it's the single biggest decision per task) and switched the default from 'isolated_worktree' to 'direct'. The schema + task-service defaults follow. Note in the schema/UI is honest about the executor still using a worktree under the hood until 'direct' is wired downstream. Polish: 'Met en file la PR via gh pr merge --squash --auto' — indecipherable to a non-technical user. Replaced both languages with 'Squash-merge the PR as soon as it's green. If your branch has required CI checks or reviews, the merge waits for them.' 247/247 still pass.
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 5 to 6. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v5...v6) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/github_actions/pnpm/action-setup-6
branch
from
92c3114 to
f90f90a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pnpm/action-setup from 5 to 6.
Release notes
Sourced from pnpm/action-setup's releases.
Commits
26f6d4ffix: use npm co-located with the action node binary (#239)903f9c1fix: update pnpm to 11.0.0-rc.5bdf0af2test: add strict version-match jobs to reproduce #225 / #22771c9247fix: pnpm self-update binary shadowed by bootstrap on PATH (#230)078e9d4fix: update pnpm to 11.0.0-rc.208c4be7docs(README): update action-setup version5798914chore: update .gitignoreddffd66fix: remove accidentally committed fileb43f991fix: update pnpm to 11.0.0-rc.03852509README.md: bring versions up-to-date (#222)