Fix terminal UI regressions, font fallback handling, and hook session routing#28
Merged
Fix terminal UI regressions, font fallback handling, and hook session routing#28
Conversation
The hook now prefers CODIRIGENT_SESSION_UUID over CODIRIGENT_SESSION_ID for signal filenames. On the app side, Codex/Gemini signal routing now matches by session UUID (like Claude already did) before falling back to the legacy integer ID.
Hook-sourced resting states (Idle, ResponseReady) were being evicted from the cache after the 600s TTL, causing the detector's Working status (from the shell's CommandExecuted state) to take over.
- Clamp cell dimensions to safe minimums in compute_cell_dimensions to prevent freeze when a symbol font (e.g. Wingdings) produces zero-width or degenerate metrics - Filter known symbol/dingbat/emoji fonts from the monospace font picker - Remove terminal_font_family from theme JSON files — font choice is a user setting, not a theme property, so theme switches no longer reset it - Run sanitize_terminal_font_family once after font detection instead of every render frame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix terminal font selection and platform fallback handling
JetBrains Monoeverywhereadd terminal search and keyboard shortcut support
Cmd/Ctrl+Fterminal search action and keybinding wiringfix terminal search input and keyboard navigation
Tab/Shift+Tabnavigation across input, prev, next, and closeEnter/Spaceactivation for focused search controlsadd terminal scrollbar interactions
fix shortcut recording focus in settings
Press a shortcut...to match the supported behaviorfix layout toggle to follow saved/top-bar profiles
toggle layoutfrom the legacy hardcodedLayoutProfilecycle to the top bar/profile manager sequencefix task board shortcut conflict
Cmd/Ctrl+BCmd/Ctrl+TCmd/Ctrl+Boverlapfix hook signal routing by stable UUID/session identity
Verification
cargo fmt --allcargo check -p codirigent-ui --features gpui-fullcodirigent-uitests for terminal search, layout profile cycling, and top bar active-profile clearing