Return a promise from transaction as per README and transaction error handling improvements#113
Merged
ospfranco merged 3 commits intoospfranco:mainfrom Jan 20, 2023
pbbadenhorst:feat/transaction-returns-promise
Merged
Return a promise from transaction as per README and transaction error handling improvements#113ospfranco merged 3 commits intoospfranco:mainfrom pbbadenhorst:feat/transaction-returns-promise
ospfranco merged 3 commits intoospfranco:mainfrom
pbbadenhorst:feat/transaction-returns-promise
Conversation
pbbadenhorst
commented
Jan 19, 2023
| executeAsync: ( | ||
| query: string, | ||
| params?: any[] | undefined | ||
| ) => Promise<QueryResult>; |
Contributor
Author
There was a problem hiding this comment.
Changed to match actual return
pbbadenhorst
commented
Jan 19, 2023
| fn: (tx: TransactionAsync) => Promise<any> | ||
| ) => Promise<void>; | ||
| transaction: (dbName: string, fn: (tx: Transaction) => void) => void; | ||
| transaction: (dbName: string, fn: (tx: Transaction) => void) => Promise<void>; |
Contributor
Author
There was a problem hiding this comment.
This is the main change - to match the README documentation
pbbadenhorst
commented
Jan 19, 2023
| return new Promise((resolve, reject) => { | ||
| const tx: PendingTransaction = { | ||
| start: () => { | ||
| run().then(resolve).catch(reject); |
Contributor
Author
There was a problem hiding this comment.
Refactored the body out
Owner
|
To be honest, now that the transactions are returning promises, there is no need for transactionAync... I think I will scratch that entire section and just have one "transaction" method. I will just merge your PR and work on the refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice that the changes in README for previous PR expected transaction to return a Promise. This PR implements that.
This PR contains.
transaction.