Adding support for BLOB columns (mapped to ArrayBuffer) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice thanks a lot for the PR! |
Owner
|
Released under 1.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for
BLOB-type SQLite columns, which map toArrayBuffers in JavaScript.You can see this support in action with the new user avatars I've added to the example app. (Obviously, using
BLOBs in the way demonstrated there is inefficient—but convenient for example purposes)This implementation can write to BLOB columns from
ArrayBuffers with zero copies, but unfortunately requires a copy to read; see facebook/hermes#564 for the JSI support which would be necessary to avoid that.Closes #11.