Skip to content

Re-write the main binding to use a proxy object to avoid global scope#62

Merged
ospfranco merged 3 commits intomainfrom
proxy-object
Jul 5, 2022
Merged

Re-write the main binding to use a proxy object to avoid global scope#62
ospfranco merged 3 commits intomainfrom
proxy-object

Conversation

@ospfranco
Copy link
Copy Markdown
Owner

closes #59

@EduFrazao would you mind taking a look and doing a quick test?

@ospfranco ospfranco requested a review from EduFrazao July 4, 2022 17:12
@ospfranco ospfranco self-assigned this Jul 4, 2022
@ospfranco
Copy link
Copy Markdown
Owner Author

I also changed how the module was initialized by using a blocking synchronous method, hopefully that will take care of the bindings failing to install every once in a while (after simulator reload for example)

@EduFrazao
Copy link
Copy Markdown
Collaborator

closes #59

@EduFrazao would you mind taking a look and doing a quick test?

Hi @ospfranco .. Sure, I will do that tonight!

@ospfranco
Copy link
Copy Markdown
Owner Author

ospfranco commented Jul 5, 2022

Everything looks stable to me, I will release it now and you can do a test later! thanks!

@ospfranco ospfranco merged commit ef05c17 into main Jul 5, 2022
@ospfranco ospfranco deleted the proxy-object branch July 5, 2022 05:53
@EduFrazao
Copy link
Copy Markdown
Collaborator

Everything looks stable to me, I will release it now and you can do a test later! thanks!

@ospfranco Hi. Sorry for the late response.
Everything seems stable here too. I've made tests with the new QuickSQLite and with IDBConnection (that I use most).

I have a doubt: My project is TypeScript, so my lint reads index.d.ts from lib/typescript. I fixed this file with this new changes, but I noted that this file folder is in the git ignore list. Is this correct?

@EduFrazao
Copy link
Copy Markdown
Collaborator

Everything looks stable to me, I will release it now and you can do a test later! thanks!

@ospfranco Hi. Sorry for the late response. Everything seems stable here too. I've made tests with the new QuickSQLite and with IDBConnection (that I use most).

I have a doubt: My project is TypeScript, so my lint reads index.d.ts from lib/typescript. I fixed this file with this new changes, but I noted that this file folder is in the git ignore list. Is this correct?

@ospfranco Please, disconsider this doubt. I've noted that this file is auto-generated when attached to the consumer project.
I'm already running the 4.0 version here!
Everything seems fine!

@ospfranco
Copy link
Copy Markdown
Owner Author

I don't quite understand what you mean, but please do open a new issue with more details

@EduFrazao
Copy link
Copy Markdown
Collaborator

I don't quite understand what you mean, but please do open a new issue with more details

It's not a issue. I was thinking that the index.d.ts must be manually updated, but this file is auto-generated. So, there is no need to change anything on the 4.0 release.
Everything seems to work fine with QuickSQLite and with IDBConnection.

Thank you for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid global scope

2 participants