Skip to content

Add an async version of transactions#64

Merged
ospfranco merged 4 commits intomainfrom
async-transaction
Jul 26, 2022
Merged

Add an async version of transactions#64
ospfranco merged 4 commits intomainfrom
async-transaction

Conversation

@ospfranco
Copy link
Copy Markdown
Owner

@ospfranco ospfranco commented Jul 11, 2022

closes #43

@EduFrazao can you test if it is working properly on your end?

@ospfranco ospfranco added the enhancement New feature or request label Jul 11, 2022
@ospfranco ospfranco requested a review from EduFrazao July 11, 2022 05:29
@ospfranco ospfranco self-assigned this Jul 11, 2022
@EduFrazao
Copy link
Copy Markdown
Collaborator

closes #43

@EduFrazao can you test if it is working properly on your end?

Hi @ospfranco . A Very nice feature. Sure, I will do my tests tonight, I have several async transactions here with hundreds of SQL Statements where I can try your code!
Thank you!!

@ospfranco
Copy link
Copy Markdown
Owner Author

@EduFrazao did you have some time to test this?

@EduFrazao
Copy link
Copy Markdown
Collaborator

@EduFrazao did you have some time to test this?

Hi @ospfranco . I'm really sorry but one of applications (that makes heavy use of quick-sqlite) has been deployed in production this week, replacing an old Cordova/IONIC. This has been a busy week. I wil do my best to test this changes today and let you know. Sorry for this delay.

@ospfranco
Copy link
Copy Markdown
Owner Author

no worries :D good luck with the release!

Comment thread src/index.ts
) => StatementResult;
detach: (mainDbName: string, alias: string) => StatementResult;
transaction: (dbName: string, fn: (tx: Transaction) => boolean) => void;
asyncTransaction: (
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the asyncTransaction method to IDBConnection to keep it feature equivalent with ISQLite?

Copy link
Copy Markdown
Collaborator

@EduFrazao EduFrazao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ospfranco. Sorry for the late response. I've made many tests with a bunch of large transactions running on the Async API and everything seems fine.
I only added asyncTransaction to IDBConnection because I like to use it on my projects, as I use a wrapper around a opened connections that holds a reference to it.

Added AsyncTransaction API for IBConnection interface
@ospfranco ospfranco merged commit 3ea2584 into main Jul 26, 2022
@ospfranco ospfranco deleted the async-transaction branch July 26, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JS async transactions

2 participants