remove argparse as it was moved to the python standard library as of python 3.2 and python 2.7#95
Closed
mattf9 wants to merge 2 commits intoosquery:masterfrom
mattf9:master
Closed
remove argparse as it was moved to the python standard library as of python 3.2 and python 2.7#95mattf9 wants to merge 2 commits intoosquery:masterfrom mattf9:master
mattf9 wants to merge 2 commits intoosquery:masterfrom
mattf9:master
Conversation
…python 3.2 and python 2.7
remove argparse as it was moved to the python standard library as of …
|
Member
|
Hi @mattf9 Thank you for submitting this. Any issues with the CLA? |
Author
|
Hello Seph. no issues with the CLA - i can close this PR and recreate as CLA compliant if you want - LMK (github newb). Thanks.On Jul 12, 2024, at 9:45 PM, seph ***@***.***> wrote:
Hi @mattf9 Thank you for submitting this. Any issues with the CLA?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Hi @mattf9 We cannot accept code that does not come with a signed CLA. You can do this by editing your commits to match the email github (and thus EasyCLA) uses, or by opening a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove argparse as it was moved to the python standard library as of python 3.2 and python 2.7
Including this requirement causes idempotence issues with configuration management systems:
https://www.reddit.com/r/learnpython/comments/uj3dhx/why_does_pip_keep_reinstalling_the_same_version/?rdt=57231
python 3.2 and 2.7 have been end-of-life for several years: https://devguide.python.org/versions/