Fix for deprecated RegEnumKey API usage#8751
Open
sinclairjw wants to merge 3 commits intoosquery:masterfrom
Open
Fix for deprecated RegEnumKey API usage#8751sinclairjw wants to merge 3 commits intoosquery:masterfrom
sinclairjw wants to merge 3 commits intoosquery:masterfrom
Conversation
| return std::nullopt; | ||
| } | ||
|
|
||
| if (max_name_length > 255) { |
Contributor
Author
There was a problem hiding this comment.
Yes, this is incorrect. Should be 16,383 as max value name limit not key name.
Member
There was a problem hiding this comment.
I think we are probably ready to proceed with this PR once this is updated. Thanks!
Member
There was a problem hiding this comment.
I attempted a fix. I pushed it into this PR
directionless
force-pushed
the
fix-deprecated-registry-api
branch
from
bc65102 to
4baba24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getRoamingProfileSids method uses the deprecated Windows registry API RegEnumKey.
This PR updates the API to RegEnumKeyEx without changing any other logic or functionality.
The change has been tested and debugged locally, and no issues found,