Merged
Conversation
* add double sided materail param Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix loading param Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #418 +/- ##
==========================================
+ Coverage 86.42% 86.43% +0.01%
==========================================
Files 60 60
Lines 9294 9304 +10
==========================================
+ Hits 8032 8042 +10
Misses 1262 1262
Continue to review full report at Codecov.
|
chapulina
approved these changes
Nov 17, 2020
Member
|
some odd windows test failures after merging with |
Member
|
@osrf-jenkins run tests please |
Member
|
now the windows build is failing with an internal compiler error: I'm going to take that build machine offline and try again |
Member
|
@osrf-jenkins run tests please |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of pull request #410