Skip to content

Enable non portalled rendering for popovers#612

Merged
krokosik merged 1 commit intomainfrom
fix-610-calendar-inside-drawer
Apr 12, 2026
Merged

Enable non portalled rendering for popovers#612
krokosik merged 1 commit intomainfrom
fix-610-calendar-inside-drawer

Conversation

@krokosik
Copy link
Copy Markdown
Collaborator

Fixes #610

Cause: this is a portal/layering interaction bug between Radix Popover and Vaul Drawer on mobile.

  • In DateSelector, calendar is rendered in PopoverContent
  • PopoverContent always portals to document.body
  • On mobile, AppDrawer uses Vaul DrawerContent, which treats pointer events outside drawer content as outside interaction/dismiss.
  • So when one taps a day, the tap target is in a portaled node outside the drawer subtree, and Vaul dismisses before react-day-picker selection runs.
  • Desktop uses Radix Dialog, whose dismissable layer integration behaves better with portaled popovers.

This adds an option to render popovers without portals.

@krokosik krokosik merged commit 0c58984 into main Apr 12, 2026
1 check passed
@krokosik krokosik deleted the fix-610-calendar-inside-drawer branch April 12, 2026 08:48
javipelopi pushed a commit to javipelopi/split-pro that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to change date of settlement

1 participant