fix(LanguagePicker): use the language-specific empty-state key#642
Merged
krokosik merged 1 commit intooss-apps:mainfrom May 8, 2026
Merged
Conversation
The 'No language found' placeholder did not exist (oss-apps#635). The component looked up account.change_language_details.no_currency_found, which is not defined in the language sub-tree, so the picker rendered the raw i18n key when a search filter matched nothing. Switch the lookup to account.change_language_details.no_language_found and add the matching English string. Other locales pick this key up through the existing Weblate flow. Closes oss-apps#635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #635.
What
When the language picker's search filter matched nothing, the picker rendered the raw i18n key
ui.change_language_details.no_currency_foundinstead of a translated string.LanguagePickerwas looking upaccount.change_language_details.no_currency_found, which is not defined in the language sub-tree ofpublic/locales/en/common.json(onlytitle,placeholder, andmessages.language_changedexist there).no_currency_foundis a sibling of the currency picker's locale tree, not the language picker's.Change
src/components/Account/LanguagePicker.tsx: switchnoOptionsTextlookup toaccount.change_language_details.no_language_found.public/locales/en/common.json: add"no_language_found": "No language found."next totitle/placeholderinaccount.change_language_details. Per CONTRIBUTING.md, the other locales pick this key up through the existing Weblate flow.Test plan
pnpm dev, sign in, open Account → Change language.asdasdin the picker.ui.change_language_details.no_currency_found.AI disclosure
Drafted with AI assistance (Claude). The diff is minimal and reviewed manually.