Skip to content

Remove old dependencies#12

Merged
GrahamCampbell merged 5 commits intomainfrom
remove-old-deps
Apr 26, 2026
Merged

Remove old dependencies#12
GrahamCampbell merged 5 commits intomainfrom
remove-old-deps

Conversation

@GrahamCampbell
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy subprocess-related dependencies by introducing a shared spawn helper and updating affected runtime code and unit tests to use it.

Changes:

  • Added src/utils/spawn.js, a promise-based spawn wrapper that captures stdout/stderr buffers and redacts sensitive CLI args in error messages.
  • Replaced cross-spawn / child-process-ext/spawn usage in framework component execution and configuration TS-node resolution with the shared helper.
  • Updated/added unit tests to cover the new spawn helper behavior and adjusted framework tests to stub the new spawn import.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/utils/spawn.js New shared spawn wrapper (buffers + redacted error messages) to replace older spawn dependencies.
components/framework/index.js Switches framework CLI execution and version detection to the shared spawn helper.
src/configuration/read.js Switches npm-based global ts-node resolution to the shared spawn helper.
test/unit/src/utils/spawn.test.js Adds unit coverage for spawn helper behavior (stdio handling, buffering, redaction, error propagation).
test/unit/components/framework/index.test.js Updates proxyquire stubs to target the shared spawn helper and adds coverage for the promise-like spawn shape.
package.json Removes old deps (child-process-ext, ci-info, path2) and bumps cross-spawn.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/utils/spawn.js Outdated
Comment thread src/utils/spawn.js Outdated
Comment thread src/utils/spawn.js
Comment thread test/unit/src/utils/spawn.test.js Outdated
@GrahamCampbell GrahamCampbell marked this pull request as ready for review April 26, 2026 23:12
@GrahamCampbell GrahamCampbell merged commit bba629c into main Apr 26, 2026
3 checks passed
@GrahamCampbell GrahamCampbell deleted the remove-old-deps branch April 26, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants