Remove old dependencies#12
Merged
GrahamCampbell merged 5 commits intomainfrom Apr 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes legacy subprocess-related dependencies by introducing a shared spawn helper and updating affected runtime code and unit tests to use it.
Changes:
- Added
src/utils/spawn.js, a promise-based spawn wrapper that captures stdout/stderr buffers and redacts sensitive CLI args in error messages. - Replaced
cross-spawn/child-process-ext/spawnusage in framework component execution and configuration TS-node resolution with the shared helper. - Updated/added unit tests to cover the new spawn helper behavior and adjusted framework tests to stub the new spawn import.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/spawn.js |
New shared spawn wrapper (buffers + redacted error messages) to replace older spawn dependencies. |
components/framework/index.js |
Switches framework CLI execution and version detection to the shared spawn helper. |
src/configuration/read.js |
Switches npm-based global ts-node resolution to the shared spawn helper. |
test/unit/src/utils/spawn.test.js |
Adds unit coverage for spawn helper behavior (stdio handling, buffering, redaction, error propagation). |
test/unit/components/framework/index.test.js |
Updates proxyquire stubs to target the shared spawn helper and adds coverage for the promise-like spawn shape. |
package.json |
Removes old deps (child-process-ext, ci-info, path2) and bumps cross-spawn. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.