Remove the ramda dependency#19
Merged
GrahamCampbell merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the ramda dependency by replacing its small helper usages with native JS equivalents and an in-repo safe merge helper, and adds unit tests to lock in the updated behavior (including prototype-pollution defenses).
Changes:
- Replaced
ramdahelpers (endsWith,curry/curryN,mergeRight,isEmpty) with native JS andsafeShallowAssign. - Hardened YAML parse options merging to avoid reserved-key/prototype-pollution edge cases.
- Added unit tests for
src/utils/fs, configuration path resolution, andComponentsServiceoutputs/graph edge cases.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/src/utils/fs.test.js | Adds unit coverage for path detection, file existence semantics, parsing behavior, and safe option merging. |
| test/unit/src/configuration/resolve-path.test.js | Validates config resolution order and directory-vs-file handling. |
| test/unit/src/components-service.test.js | Covers outputs behavior with null-prototype registries and empty graph execution behavior. |
| src/utils/fs/readFileSync.js | Removes Ramda currying; keeps behavior via plain function signature. |
| src/utils/fs/readFile.js | Removes Ramda currying; keeps behavior via plain function signature. |
| src/utils/fs/parseFile.js | Replaces mergeRight with safeShallowAssign for safer YAML options merging; removes currying. |
| src/utils/fs/isYamlPath.js | Replaces Ramda endsWith with String.prototype.endsWith. |
| src/utils/fs/isJsonPath.js | Replaces Ramda endsWith with String.prototype.endsWith. |
| src/utils/fs/fileExists.js | Removes Ramda curry; keeps async behavior unchanged. |
| src/ComponentsService.js | Replaces Ramda isEmpty checks with explicit .length / Object.keys().length checks. |
| package.json | Removes ramda from dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.