Test service-specific Framework command passthrough#8
Merged
GrahamCampbell merged 1 commit intomainfrom Apr 26, 2026
Merged
Conversation
Co-authored-by: Jordan Craw <jordan.craw@hurricanecommerce.com> Co-authored-by: Jordan Ashley Craw <27454899+rageycomma@users.noreply.github.com>
a4871a4 to
5370fbc
Compare
There was a problem hiding this comment.
Pull request overview
Adds regression coverage and minor runtime/supporting changes to ensure Serverless Framework “service-specific passthrough” commands (including nested forms like deploy:function and invoke:local) are preserved end-to-end in Compose, and documents the nested command forms in CLI help output.
Changes:
- Add unit tests covering nested service-specific command parsing/routing and options validation behavior.
- Add help-output examples demonstrating nested service-specific commands.
- Update Framework component CLI argument formatting to preserve repeated passthrough options (e.g.,
--envmultiple times).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/src/validate-options.test.js | Adds regression test ensuring nested passthrough commands aren’t rejected by Compose option validation. |
| test/unit/src/render-help.test.js | Verifies help output includes nested service-specific command examples. |
| test/unit/src/index.test.js | Tests CLI argv parsing preserves nested commands for service:command:subcommand and --service forms. |
| test/unit/src/components-service.test.js | Ensures nested commands are passed through to Framework services without being rewritten. |
| test/unit/components/framework/index.test.js | Validates nested Framework commands translate to correct serverless argv; adds coverage for repeated passthrough options. |
| src/render-help.js | Adds “Examples” section showing nested service-specific command usage. |
| components/framework/index.js | Expands array-valued options into repeated CLI params and centralizes param formatting logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy:function,deploy:list:functions,rollback:function,invoke, andinvoke:local.invoke local --env.