Improve progress messages for Framework passthrough commands#9
Merged
GrahamCampbell merged 2 commits intomainfrom Apr 26, 2026
Merged
Improve progress messages for Framework passthrough commands#9GrahamCampbell merged 2 commits intomainfrom
GrahamCampbell merged 2 commits intomainfrom
Conversation
GrahamCampbell
force-pushed
the
pr/framework-command-progress
branch
from
c5d41d0 to
8260b4e
Compare
There was a problem hiding this comment.
Pull request overview
Adds user-facing progress labels for a set of common Serverless Framework passthrough commands, improving UX consistency while keeping command execution behavior (routing, validation, stdio inheritance) the same.
Changes:
- Introduces a command→progress-text mapping for selected passthrough commands and formats messages with function names when provided.
- Wraps passthrough command execution with
startProgress/successProgressfor those commands. - Adds unit tests validating progress behavior for known and unknown passthrough commands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
components/framework/index.js |
Adds progress text mapping + formatting and emits progress events around selected passthrough commands. |
test/unit/components/framework/index.test.js |
Adds unit coverage for command-specific progress messages and ensures unknown commands don’t trigger special progress. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Jordan Craw <jordan.craw@hurricanecommerce.com> Co-authored-by: Jordan Ashley Craw <27454899+rageycomma@users.noreply.github.com>
GrahamCampbell
force-pushed
the
pr/framework-command-progress
branch
from
9f4f694 to
97f2b67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy:function,deploy:list,deploy:list:functions,rollback:function,invoke, andinvoke:local.