Clean up partial remote package artifact downloads on failure#289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote S3 package artifact downloads could leave a partially written temp file behind when the download or the destination write stream failed, because the streamed write to disk was not wrapped in any cleanup. This wraps that write so that a failed download or write removes the partial temp file before re-throwing the original error, and it ignores any cleanup error so cleanup never masks the underlying download or write failure. It also adds unit tests covering removal of the partial temp file on failure, a missing temp file being ignored during cleanup, and a cleanup failure not masking the original error.
Fixes #220.