Move to head bucket to ensure a deployment bucket is in the right region #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engerim
force-pushed
the
fix-deployment-bucket-inus-east-1
branch
from
0562ee1 to
bdb5dc6
Compare
When the bucket is in us-east-1, aws sdk v3 returns for getBucketLocation no value as it is null, aws sdk v2 returned an empty string moving to headBucket a region is always returned https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html
Engerim
force-pushed
the
fix-deployment-bucket-inus-east-1
branch
from
bdb5dc6 to
5eef1a5
Compare
Contributor
|
Thanks! |
Contributor
|
FYI reverted in #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bucket is in
us-east-1, aws sdk v3 returns forgetBucketLocationno value as it is null, aws sdk v2 returned an empty string moving toheadBucketa region is always returned https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html