Report root stack deletion failures during create#169
Merged
GrahamCampbell merged 2 commits intomainfrom Apr 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Detects and reports root stack DELETE_IN_PROGRESS during non-delete stack monitoring as a deployment failure, preserving the CloudFormation failure reason instead of later failing with a missing-stack error.
Changes:
- Treats root stack
DELETE_IN_PROGRESSas an error signal duringcreate/updatemonitoring and captures the CF failure reason early. - Adds unit tests covering root
DELETE_IN_PROGRESSbehavior (non-verbose + verbose-with-cleanup) and ensuring nested stack deletes during update do not trigger a root-failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/plugins/aws/lib/monitor-stack.js | Flags root stack DELETE_IN_PROGRESS as a failure during non-delete monitoring to preserve the underlying CF reason. |
| test/unit/lib/plugins/aws/lib/monitor-stack.test.js | Adds regression tests for root delete-in-progress failure reporting and a nested-stack non-regression case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs serverless/serverless#13181