Skip to content

Report root stack deletion failures during create#169

Merged
GrahamCampbell merged 2 commits intomainfrom
fix/root-delete-in-progress-failure
Apr 26, 2026
Merged

Report root stack deletion failures during create#169
GrahamCampbell merged 2 commits intomainfrom
fix/root-delete-in-progress-failure

Conversation

@GrahamCampbell
Copy link
Copy Markdown
Contributor

Summary

  • Detect root stack DELETE_IN_PROGRESS during non-delete stack monitoring as a deployment failure.
  • Preserve the CloudFormation failure reason instead of later failing with a missing-stack error.

Refs serverless/serverless#13181

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Detects and reports root stack DELETE_IN_PROGRESS during non-delete stack monitoring as a deployment failure, preserving the CloudFormation failure reason instead of later failing with a missing-stack error.

Changes:

  • Treats root stack DELETE_IN_PROGRESS as an error signal during create/update monitoring and captures the CF failure reason early.
  • Adds unit tests covering root DELETE_IN_PROGRESS behavior (non-verbose + verbose-with-cleanup) and ensuring nested stack deletes during update do not trigger a root-failure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/plugins/aws/lib/monitor-stack.js Flags root stack DELETE_IN_PROGRESS as a failure during non-delete monitoring to preserve the underlying CF reason.
test/unit/lib/plugins/aws/lib/monitor-stack.test.js Adds regression tests for root delete-in-progress failure reporting and a nested-stack non-regression case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/plugins/aws/lib/monitor-stack.js Outdated
@GrahamCampbell GrahamCampbell merged commit f47f523 into main Apr 26, 2026
3 checks passed
@GrahamCampbell GrahamCampbell deleted the fix/root-delete-in-progress-failure branch April 26, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants