Improved linting

eslint.config.js

@@ -46,7 +46,12 @@ module.exports = [
         },
       ],
       'import-x/no-unresolved': ['error', { commonjs: true }],
-      'no-unused-vars': ['error', { caughtErrors: 'none' }],
+      'no-unused-vars': [
+        'error',
+        {
+          caughtErrors: 'all',
+        },
+      ],
       'n/no-unsupported-features/node-builtins': ['error', { allowExperimental: true }],
       'n/no-extraneous-require': 'off',
       'n/no-unpublished-require': 'off',
@@ -56,6 +61,12 @@ module.exports = [
       'n/hashbang': 'off',
     },
   },
+  {
+    files: ['bin/serverless.js', 'commands/**/*.js', 'lib/**/*.js', 'scripts/serverless.js'],
+    rules: {
+      'n/no-unpublished-require': 'error',
+    },
+  },
   {
     files: ['**/*.mjs'],
     languageOptions: {

lib/cli/run-compose.js

@@ -28,15 +28,15 @@ const resolveGlobalNpmPath = async () => {
   const npmNodeModulesPath = await (async () => {
     try {
       return String((await spawn('npm', ['root', '-g'])).stdoutBuffer).trim();
-    } catch (error) {
+    } catch {
       return null;
     }
   })();
 
   if (!npmNodeModulesPath) return null;
   try {
     return require.resolve(`${npmNodeModulesPath}/${relativeBinPath}`);
-  } catch (globalDepError) {
+  } catch {
     return null;
   }
 };

lib/configuration/variables/resolve.js

@@ -648,7 +648,7 @@ Object.defineProperties(
         let normalizedResultValue;
         try {
           normalizedResultValue = JSON.parse(JSON.stringify(resultValue));
-        } catch (error) {
+        } catch {
           throw new VariableSourceResolutionError(
             `Source "${sourceData.type}" returned not supported result: "${util.inspect(
               resultValue

lib/configuration/variables/sources/file.js

@@ -93,7 +93,7 @@ module.exports = {
         case '.cjs': {
           try {
             require.resolve(filePath);
-          } catch (error) {
+          } catch {
             return null;
           }
           let result;

lib/plugins/aws/deploy/lib/ensure-valid-bucket-exists.js

@@ -80,10 +80,10 @@ module.exports = {
     if (getTemplateResult.TemplateBody) {
       try {
         templateBody = JSON.parse(getTemplateResult.TemplateBody);
-      } catch (error) {
+      } catch {
         try {
           templateBody = jsyaml.load(getTemplateResult.TemplateBody);
-        } catch (error2) {
+        } catch {
           throw new ServerlessError(
             'Could not parse CloudFormation template',
             'CLOUDFORMATION_TEMPLATE_PARSE_FAILED'

lib/plugins/aws/invoke-local/index.js

@@ -135,7 +135,7 @@ class AwsInvokeLocal {
           this.options.context = JSON.parse(this.options.context);
         }
       }
-    } catch (exception) {
+    } catch {
       // do nothing if it's a simple string or object already
     }
   }
@@ -704,7 +704,7 @@ class AwsInvokeLocal {
 
     try {
       await fsp.stat(executablePath);
-    } catch (err) {
+    } catch {
       return new Promise((resolve, reject) => {
         const javaBridgeProgress = progress.get('javaBridge');
         javaBridgeProgress.notice('Building Java bridge', { isMainEvent: true });
@@ -883,7 +883,7 @@ class AwsInvokeLocal {
       }
       try {
         JSON.stringify(result);
-      } catch (error) {
+      } catch {
         throw new ServerlessError(
           `Function returned invalid (not a JSON stringifiable) value: ${inspect(result)}`,
           'INVALID_INVOKE_LOCAL_RESULT'
@@ -896,7 +896,7 @@ class AwsInvokeLocal {
             Object.assign(result, {
               body: JSON.parse(result.body),
             });
-          } catch (e) {
+          } catch {
             throw new ServerlessError(
               'Content-Type of response is application/json but body is not json',
               'INVOKE_LOCAL_RESPONSE_TYPE_MISMATCH'

lib/plugins/aws/invoke.js

@@ -61,15 +61,15 @@ class AwsInvoke {
       if (!this.options.raw) {
         this.options.data = JSON.parse(this.options.data);
       }
-    } catch (exception) {
+    } catch {
       // do nothing if it's a simple string or object already
     }
 
     try {
       if (!this.options.raw && this.options.context) {
         this.options.context = JSON.parse(this.options.context);
       }
-    } catch (exception) {
+    } catch {
       // do nothing if it's a simple string or object already
     }
   }

lib/plugins/aws/provider.js

@@ -2299,7 +2299,7 @@ Object.defineProperties(
       async () => {
         try {
           await spawnExt('docker', ['--version']);
-        } catch (err) {
+        } catch {
           throw new ServerlessError(
             'Could not find Docker installation. Ensure Docker is installed before continuing.',
             'DOCKER_COMMAND_NOT_AVAILABLE'

lib/plugins/package/lib/zip-service.js

@@ -288,7 +288,7 @@ async function excludeNodeDevDependencies(serviceDir) {
       fsp.unlink(nodeProdDepFile).catch(() => {}),
     ]);
     return exAndIn;
-  } catch (e) {
+  } catch {
     // fail silently
     return exAndIn;
   }

lib/utils/fs/dir-exists-sync.js

@@ -6,7 +6,7 @@ function dirExistsSync(dirPath) {
   try {
     const stats = fse.statSync(dirPath);
     return stats.isDirectory();
-  } catch (e) {
+  } catch {
     return false;
   }
 }

lib/utils/fs/file-exists-sync.js

@@ -6,7 +6,7 @@ function fileExistsSync(filePath) {
   try {
     const stats = fse.statSync(filePath);
     return stats.isFile();
-  } catch (e) {
+  } catch {
     return false;
   }
 }

test/fixtures/programmatic/plugin/extend-config-plugin/index.js

@@ -28,21 +28,21 @@ module.exports = class TestPlugin {
 
     try {
       this.serverless.extendConfiguration([], { custom: {} });
-    } catch (error) {
+    } catch {
       // ignore this
     }
 
     try {
       this.serverless.extendConfiguration('custom.target.invalid', {});
-    } catch (error) {
+    } catch {
       // ignore this
     }
   }
 
   extendAfterInit() {
     try {
       this.serverless.extendConfiguration(pluginConfig.afterInitValuePath, 'value');
-    } catch (error) {
+    } catch {
       // ignore this
     }
   }

test/integration/aws/websocket.test.js

@@ -59,7 +59,7 @@ describe('AWS - API Gateway Websocket Integration Test', function () {
           promiseReject(error);
           try {
             ws.close();
-          } catch (closeError) {
+          } catch {
             // safe to ignore
           }
         })(reject);
@@ -102,7 +102,7 @@ describe('AWS - API Gateway Websocket Integration Test', function () {
           promiseReject(error);
           try {
             ws.close();
-          } catch (closeError) {
+          } catch {
             // safe to ignore
           }
         })(reject);

test/lib/setup-fixtures-engine.js

@@ -118,7 +118,7 @@ module.exports = memoizee((fixturesPath) => {
         (() => {
           try {
             return loadYaml(configContent, { schema: cloudformationSchema });
-          } catch (error) {
+          } catch {
             return null;
           }
         })();

test/unit/lib/classes/plugin-manager.test.js

@@ -1614,7 +1614,7 @@ describe('PluginManager', () => {
       process.chdir(cwd);
       try {
         fse.removeSync(tmpDir);
-      } catch (e) {
+      } catch {
         // Couldn't delete temporary file
       }
     });

test/unit/lib/config-schema.test.js

@@ -101,7 +101,7 @@ describe('test/unit/lib/configSchema.test.js', () => {
         (err) => {
           try {
             expect(err.message).to.include(someCase.errorMessage);
-          } catch (error) {
+          } catch {
             throw err;
           }
         }

test/unit/lib/plugins/aws/invoke-local/index.test.js

@@ -1789,7 +1789,7 @@ describe('test/unit/lib/plugins/aws/invokeLocal/index.test.js', () => {
       const executable = process.platform === 'win32' ? 'python.exe' : 'python';
       try {
         await spawnExt(executable, ['--version']);
-      } catch (err) {
+      } catch {
         skipWithNotice(this, 'Python runtime is not installed');
       }
     });
@@ -1815,7 +1815,7 @@ describe('test/unit/lib/plugins/aws/invokeLocal/index.test.js', () => {
       const executable = process.platform === 'win32' ? 'ruby.exe' : 'ruby';
       try {
         await spawnExt(executable, ['--version']);
-      } catch (err) {
+      } catch {
         skipWithNotice(this, 'Ruby runtime is not installed');
       }
     });

test/utils/aws-cleanup.js

@@ -62,7 +62,7 @@ async function cleanup() {
     const promises = bucketsToRemove.map((bucket) => deleteBucket(bucket.PhysicalResourceId));
     try {
       await Promise.all(promises);
-    } catch (error) {
+    } catch {
       // do nothing... try to continue with cleanup
     }
   }
@@ -72,7 +72,7 @@ async function cleanup() {
     const promises = stacksToRemove.map((stack) => deleteStack(stack.StackName));
     try {
       await Promise.all(promises);
-    } catch (error) {
+    } catch {
       // do nothing... try to continue with cleanup
     }
   }
@@ -82,7 +82,7 @@ async function cleanup() {
     const promises = apisToRemove.map((api) => deleteRestApi(api.id));
     try {
       await Promise.all(promises);
-    } catch (error) {
+    } catch {
       // do nothing... try to continue with cleanup
     }
   }
@@ -92,7 +92,7 @@ async function cleanup() {
     const promises = userPoolsToRemove.map((userPool) => deleteUserPoolById(userPool.Id));
     try {
       await Promise.all(promises);
-    } catch (error) {
+    } catch {
       // do nothing... try to continue with cleanup
     }
   }

test/utils/integration.js

@@ -27,7 +27,7 @@ async function resolveServiceName(cwd) {
   const configObject = (() => {
     try {
       return loadYaml(configContent);
-    } catch (error) {
+    } catch {
       return null;
     }
   })();