Scope deploy-list S3 prefix to exact stage#192
Merged
GrahamCampbell merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the S3 listing prefix used by deploy list so that deployment artifacts are scoped to the exact stage directory (avoiding accidental matches on similarly-prefixed stage names, e.g. dev matching dev2).
Changes:
- Add a trailing
/to the S3listObjectsV2Prefix inAwsDeployList#listDeployments(). - Update unit tests to assert the new, stage-directory-scoped Prefix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/plugins/aws/deploy-list.js | Updates the S3 listing Prefix to include a trailing slash for exact stage scoping. |
| test/unit/lib/plugins/aws/deploy-list.test.js | Adjusts assertions to match the updated Prefix format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.