Inline stdin reader for AWS invoke commands#235
Merged
GrahamCampbell merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the external get-stdin dependency with an internal stdin reader utility and updates AWS invoke paths/tests accordingly, reducing third-party surface area while keeping invoke/invoke-local behavior consistent.
Changes:
- Added
lib/utils/get-stdin.jsto read piped stdin (supports string/byte chunks, strips UTF-8 BOM, preserves multibyte correctness). - Switched AWS
invokeandinvoke-localto use the internal utility instead of theget-stdinpackage. - Added unit coverage for the new stdin utility and updated proxyquire paths in invoke-local tests; removed
get-stdinfrompackage.json.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/utils/get-stdin.js | Introduces internal async stdin reader used by invoke flows. |
| lib/plugins/aws/invoke.js | Replaces get-stdin dependency import with internal util. |
| lib/plugins/aws/invoke-local/index.js | Replaces get-stdin dependency import with internal util. |
| test/unit/lib/utils/get-stdin.test.js | Adds unit tests covering chunk types, BOM stripping, and error cases. |
| test/unit/lib/plugins/aws/invoke-local/index.test.js | Updates proxyquire stubs to match new require path. |
| package.json | Drops get-stdin from dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.