Skip to content

Inline stdin reader for AWS invoke commands#235

Merged
GrahamCampbell merged 1 commit intomainfrom
inline-get-stdin
May 2, 2026
Merged

Inline stdin reader for AWS invoke commands#235
GrahamCampbell merged 1 commit intomainfrom
inline-get-stdin

Conversation

@GrahamCampbell
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the external get-stdin dependency with an internal stdin reader utility and updates AWS invoke paths/tests accordingly, reducing third-party surface area while keeping invoke/invoke-local behavior consistent.

Changes:

  • Added lib/utils/get-stdin.js to read piped stdin (supports string/byte chunks, strips UTF-8 BOM, preserves multibyte correctness).
  • Switched AWS invoke and invoke-local to use the internal utility instead of the get-stdin package.
  • Added unit coverage for the new stdin utility and updated proxyquire paths in invoke-local tests; removed get-stdin from package.json.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/utils/get-stdin.js Introduces internal async stdin reader used by invoke flows.
lib/plugins/aws/invoke.js Replaces get-stdin dependency import with internal util.
lib/plugins/aws/invoke-local/index.js Replaces get-stdin dependency import with internal util.
test/unit/lib/utils/get-stdin.test.js Adds unit tests covering chunk types, BOM stripping, and error cases.
test/unit/lib/plugins/aws/invoke-local/index.test.js Updates proxyquire stubs to match new require path.
package.json Drops get-stdin from dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GrahamCampbell GrahamCampbell merged commit f92b02e into main May 2, 2026
8 checks passed
@GrahamCampbell GrahamCampbell deleted the inline-get-stdin branch May 2, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants