Fix paginated deployment artifact comparison

[GrahamCampbell]

Summary

• List all deployment artifact pages before selecting the latest deployment directory.
• Preserve existing missing-bucket error translation across paginated S3 responses.
• Add coverage for latest directories on later pages and split across pages.

Tests

• npx mocha --config "test/mocha/unit.cjs" "test/unit/lib/plugins/aws/deploy/lib/check-for-changes.test.js"
• npm run lint
• npm run prettier-check
• git diff --check

[Copilot]

Pull request overview

Fixes checkForChanges deployment artifact selection when the latest deployment directory is not present on the first listObjectsV2 page, ensuring correct comparison behavior for long-lived deployment buckets.

Changes:

• Iterate through all paginated S3 listObjectsV2 results before determining the most recent deployment directory.
• Preserve translation of “missing deployment bucket” errors when failures occur on later pages.
• Add unit tests covering “latest directory on later page”, “latest directory split across pages”, and “missing bucket error on later page”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
lib/plugins/aws/deploy/lib/check-for-changes.js	Updates getMostRecentObjects() to aggregate paginated S3 listings prior to selecting the newest deployment directory.
test/unit/lib/plugins/aws/deploy/lib/check-for-changes.test.js	Adds unit coverage for paginated listing scenarios and error translation on later pages.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.