Skip to content

Remove unused local AWS credential probe#261

Merged
GrahamCampbell merged 1 commit intomainfrom
remove-dead-has-local-credentials
May 3, 2026
Merged

Remove unused local AWS credential probe#261
GrahamCampbell merged 1 commit intomainfrom
remove-dead-has-local-credentials

Conversation

@GrahamCampbell
Copy link
Copy Markdown
Contributor

Summary

  • Remove the unused SDK v2-backed local credential probe helper.
  • Remove its dedicated unit test, since no runtime code imports the helper.

Validation

  • npm run prettier-check
  • npx prettier -c "../ROADMAP.md"
  • npm run lint
  • git diff --check
  • npm run test:isolated

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused AWS “local credentials probe” helper and its unit test, simplifying the AWS utility surface area since nothing imports the helper at runtime.

Changes:

  • Deleted lib/aws/has-local-credentials.js (unused AWS SDK v2-based helper).
  • Deleted test/unit/lib/aws/has-local-credentials.test.js (dedicated unit test for the removed helper).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/aws/has-local-credentials.js Removes unused helper that probed AWS.S3().config.credentials.
test/unit/lib/aws/has-local-credentials.test.js Removes unit tests for the deleted helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GrahamCampbell GrahamCampbell merged commit e2cc16f into main May 3, 2026
8 of 12 checks passed
@GrahamCampbell GrahamCampbell deleted the remove-dead-has-local-credentials branch May 3, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants