Skip to content
Discussion options

You must be logged in to vote

yes but keep them out of the source code itself. Read the app ID and installation ID from your config or environment when you build the Job, then put them into the manifest's env. The key file stays in the mounted secret, and GITHUB_APP_KEY_PATH should point to its path.
Scorecard only reads GITHUB_APP_ID, GITHUB_APP_INSTALLATION_ID and GITHUB_APP_KEY_PATH from the environment (roundtripper.go ) so as long as the manifest sets those three, your code does not need to hold any secret.

Replies: 4 comments 4 replies

Comment options

You must be logged in to vote
2 replies
@theSistasheriff
Comment options

@TheMysteriousGhost
Comment options

Comment options

You must be logged in to vote
2 replies
@theSistasheriff
Comment options

@Erfouni
Comment options

Answer selected by theSistasheriff
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
3 participants