Skip to content

Refactor bootstrap for multi-server support and add srs-develop skill. v7.0.142#4657

Merged
winlinvip merged 9 commits into
ossrs:developfrom
winlinvip:develop
Apr 6, 2026
Merged

Refactor bootstrap for multi-server support and add srs-develop skill. v7.0.142#4657
winlinvip merged 9 commits into
ossrs:developfrom
winlinvip:develop

Conversation

@winlinvip
Copy link
Copy Markdown
Member

Summary

  • Extract proxy bootstrap implementation from bootstrap.go into internal/bootstrap/proxy.go, keeping only the Bootstrap interface in the shared file. This prepares for origin/edge servers
    to have their own bootstrap implementations.
  • Rename NewBootstrap() → NewProxyBootstrap() to follow the explicit factory naming convention.
  • Rebrand signature from SRSProxy to SRSX and update logger context key accordingly.
  • Add srs-develop skill with task router, module routing workflow, proxy unit test script, and RTMP E2E test script.
  • Remove st-develop skill (superseded by srs-develop).
  • Add srs-support eval #21 for HLS AnnexB decode error scenario.

Test plan

  • go build ./cmd/proxy/... compiles successfully
  • go test ./cmd/... ./internal/... passes
  • E2E RTMP proxy test (proxy-e2e-test.sh) passes
  • Verify proxy starts and logs SRSX-Proxy/ started

winlinvip and others added 8 commits March 30, 2026 07:29
Add the srs-develop skill for AI-maintained development of the
next-generation Go SRS media server. The skill triggers on development
tasks (features, bugs, refactoring, code architecture, reviews, tests)
and explicitly excludes end-user support and usage questions.
…ature workflow

Add structured SKILL.md for srs-develop with:
- Core principle: code is the only truth, verify docs against source
- Mandatory task classification: develop feature, fix bug, learn code, review PR
- Feature development workflow with service targeting (proxy/origin/edge)
- Note that C++ server is maintenance-only, new features go to Go server
- Placeholder sections for unsupported task types (bug fix, learn, review)
- Update core principle: documents are truth alongside code, not just
  code alone. Documents capture design intent and architecture rationale.
- Rename "Develop a Feature" to "Develop Code" with broader scope
  covering features, refactoring, and documentation changes.
- Add mandatory 3-step proxy server workflow: module routing (with user
  confirmation), module understanding (docs then code), and placeholder
  for step 3.
- Add prerequisite notes to all task types enforcing Task Router usage.
- Improve codebase map with clearer section headings and doc sub-headers.
- Add inline comment to proxy main.go clarifying error logging.
Add eval testing the bot's response to HlsDecode/3001 (not annexb) error.
Verifies correct root cause identification (camera encoder), proper fix
suggestions (firmware, FFmpeg relay, restart), and absence of wrong
explanations (no blaming TCP packet loss, no hallucinated config options).

Also add bash permission for echo PID in Claude settings.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The ST development skill is removed as the knowledge and workflow
have been consolidated into the main srs-develop skill.
…op skill

Add proxy-e2e-test.sh that starts proxy + SRS origin, publishes an RTMP
stream, and verifies playback via ffprobe. Update SKILL.md Step 3 to run
both unit tests and E2E test during verification.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Split Bootstrap interface (bootstrap.go) from proxy implementation (proxy.go)
to prepare for future origin and edge bootstrap implementations. Rename
bootstrapImpl to proxyBootstrap and NewBootstrap to NewProxyBootstrap.
Also update signature and context ID to SRSX branding.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@winlinvip winlinvip changed the title Refactor bootstrap for multi-server support and add srs-develop skill Refactor bootstrap for multi-server support and add srs-develop skill. v7.0.142 Apr 6, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@winlinvip winlinvip merged commit 7c17c93 into ossrs:develop Apr 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant