Refactor bootstrap for multi-server support and add srs-develop skill. v7.0.142#4657
Merged
Conversation
Add the srs-develop skill for AI-maintained development of the next-generation Go SRS media server. The skill triggers on development tasks (features, bugs, refactoring, code architecture, reviews, tests) and explicitly excludes end-user support and usage questions.
…ature workflow Add structured SKILL.md for srs-develop with: - Core principle: code is the only truth, verify docs against source - Mandatory task classification: develop feature, fix bug, learn code, review PR - Feature development workflow with service targeting (proxy/origin/edge) - Note that C++ server is maintenance-only, new features go to Go server - Placeholder sections for unsupported task types (bug fix, learn, review)
- Update core principle: documents are truth alongside code, not just code alone. Documents capture design intent and architecture rationale. - Rename "Develop a Feature" to "Develop Code" with broader scope covering features, refactoring, and documentation changes. - Add mandatory 3-step proxy server workflow: module routing (with user confirmation), module understanding (docs then code), and placeholder for step 3. - Add prerequisite notes to all task types enforcing Task Router usage. - Improve codebase map with clearer section headings and doc sub-headers. - Add inline comment to proxy main.go clarifying error logging.
Add eval testing the bot's response to HlsDecode/3001 (not annexb) error. Verifies correct root cause identification (camera encoder), proper fix suggestions (firmware, FFmpeg relay, restart), and absence of wrong explanations (no blaming TCP packet loss, no hallucinated config options). Also add bash permission for echo PID in Claude settings.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The ST development skill is removed as the knowledge and workflow have been consolidated into the main srs-develop skill.
…op skill Add proxy-e2e-test.sh that starts proxy + SRS origin, publishes an RTMP stream, and verifies playback via ffprobe. Update SKILL.md Step 3 to run both unit tests and E2E test during verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Split Bootstrap interface (bootstrap.go) from proxy implementation (proxy.go) to prepare for future origin and edge bootstrap implementations. Rename bootstrapImpl to proxyBootstrap and NewBootstrap to NewProxyBootstrap. Also update signature and context ID to SRSX branding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to have their own bootstrap implementations.
Test plan