Add Pull Request submission guidelines to CONTRIBUTING.md#1389
Closed
ahmasmibhanu wants to merge 1 commit intoossu:masterfrom
Closed
Add Pull Request submission guidelines to CONTRIBUTING.md#1389ahmasmibhanu wants to merge 1 commit intoossu:masterfrom
ahmasmibhanu wants to merge 1 commit intoossu:masterfrom
Conversation
Member
|
The contributing guide links to a guide on how to create a pull request. This is general information that we do not want to duplicate here. Commit bf6af68 makes the link to the PR guide more explicit. Thanks for the feedback. |
|
83u
…On Fri, 6 Feb 2026, 11:23 Lenox Waciuma Wanjohi, ***@***.***> wrote:
Closed #1389 <#1389>.
—
Reply to this email directly, view it on GitHub
<#1389 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASUXEP2DBWGRZUDER4I2OML4KRFPLAVCNFSM6AAAAACTZJGIVCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGU4DCOJRGE3DEMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new “Submitting a Pull Request” section to
CONTRIBUTING.md.While the document clearly explains what types of changes are appropriate (substantive vs non-substantive), it does not currently describe how contributors should submit pull requests. This can be especially confusing for first-time contributors.
What this change does