Skip to content

feat: Option to skip lockfile update#2

Merged
osteele merged 4 commits intoosteele:mainfrom
TitaniumIT:option-to-skip-lockfile-update
Jul 13, 2025
Merged

feat: Option to skip lockfile update#2
osteele merged 4 commits intoosteele:mainfrom
TitaniumIT:option-to-skip-lockfile-update

Conversation

@MarcoFuykschot
Copy link
Copy Markdown
Contributor

No description provided.

@MarcoFuykschot
Copy link
Copy Markdown
Contributor Author

@osteele Hi i created 2 pr for some extra options/features if you have time please take look, i think this wil make the tool even better

@MarcoFuykschot MarcoFuykschot force-pushed the option-to-skip-lockfile-update branch from c496b8a to cf7cf40 Compare July 8, 2025 10:33
Comment thread src/main.rs Outdated
Comment thread src/main.rs Outdated
@osteele
Copy link
Copy Markdown
Owner

osteele commented Jul 11, 2025

Thanks, this is a solid implementation for useful feature!

I made a couple of typo comments. Also, please add a line to the README, after --no-tag:

70 +  - `--no-lockupdate` - Skip updating lock files (package-lock.json, Cargo.lock, etc.)

@osteele
Copy link
Copy Markdown
Owner

osteele commented Jul 11, 2025

By the way, for future PRs, I read that you can enable “Allow edits from maintainers” when you open a pull request. This lets me make small fixes (typos, formatting) directly on your PR branch if needed, so we can merge more quickly without extra back-and-forth. It's supposed to be an option as a checkbox in the right-hand sidebar of the PR page on GitHub. (I haven't tried this myself.) https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@MarcoFuykschot
Copy link
Copy Markdown
Contributor Author

Thanks, this is a solid implementation for useful feature!

I made a couple of typo comments. Also, please add a line to the README, after --no-tag:

70 +  - `--no-lockupdate` - Skip updating lock files (package-lock.json, Cargo.lock, etc.)

@MarcoFuykschot MarcoFuykschot requested a review from osteele July 11, 2025 12:19
@osteele osteele merged commit 885cfa5 into osteele:main Jul 13, 2025
1 check passed
osteele added a commit that referenced this pull request Jul 13, 2025
- Added entry in CHANGELOG.md for PR #2
- Updated Contributors section to credit @MarcoFuykschot for --no-lockupdate flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants