Treat deserializer compatibility as serializer output#72
Draft
ostrowr wants to merge 2 commits into
Draft
Conversation
Model Role::Deserializer against values the old serializer could actually emit, rather than every value the old schema would accept via undeclared additional properties. Add a focused regression test covering an optional property added under the default-open object semantics. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Role::Deserializeragainst values the old serializer could emit, instead of every value the old schema would accept through undeclared additional propertiesWhy
The current checker treats open object schemas as if old serializers might emit arbitrary undeclared keys. That makes an added optional property look deserializer-incompatible even when the serializer contract is "only declared fields are emitted," which is the behavior described in the README.
Validation
cargo test check_compat_treats_optional_added_property_as_deserializer_compatible --quietcargo test --test backcompat complex_optional_prop_added --quietcargo fmt --all --checkFollow-up
cargo test --quietstill fails intests/backcompat.rsforadditionalprops_reducedandpattern_properties_fall_back_to_additional_properties. Those fixtures and the fuzz confirmation harness still encode the old deserializer semantics for open object schemas, so they need a follow-up decision/update before this should leave draft.