Skip to content

Conversation

@SebouChu
Copy link
Member

@SebouChu SebouChu commented Sep 8, 2025

Fusion de #3362, #3193 et #3367 pour tout tester en staging

Fix #2876

Possibles breaking changes

  • plus de data/school.yml ou data/journal.yml, adresse dans le footer risque de disparaître. Que préférez--vous comme alternative @alexisben @Olivia206 ?

@arnaudlevy arnaudlevy added the waiting theme (olivialex approval) Label retirable UNIQUEMENT par Alex ou Olivia label Sep 9, 2025
SebouChu and others added 2 commits September 9, 2025 09:05
@alexisben
Copy link
Contributor

Dans app/views/admin/education/schools/static.html.erb, je crois que vous pouvez enlever :

address: >-
  <%= prepare_text_for_static school.address %>
zipcode: "<%= prepare_text_for_static school.zipcode %>"
city: "<%= prepare_text_for_static school.city %>"
country: "<%= prepare_text_for_static school.country_common_name %>"
phone: "<%= prepare_text_for_static school.phone %>"
website: "<%= prepare_text_for_static @l10n.url %>"

@alexisben
Copy link
Contributor

Est-ce que les contacts_details du site ne devraient pas aller dans data/websites/ plutôt que config/languages ?


fr:
  title: >-
    Recettage School
  contentDir: content/fr
  languageCode: fr
  languageName: Français
  buildFuture: true
  params:
    contact_details:
      emails:
        email:
          label: >-
            contact@osuny.org
          value: >-
            mailto:contact@osuny.org
      social_networks:
        github:
          label: >-
            osunydev/
          value: >-
            https://github.com/osunydev/

@alexisben
Copy link
Contributor

C'est p-e lié a un pb de clean dans le commit, mais ces données sont générées dans data/website :

https://github.com/osunydev/recettage-school/blob/main/data/website/en.yml#L8-L11

contents_reading_time:
  seconds: 0
  text: >-
    less than a minute

@SebouChu
Copy link
Member Author

@alexisben ça fait partie du partial qui gère les blocs dans les static, c'est pas très grave

@SebouChu SebouChu merged commit 572021f into main Sep 18, 2025
4 of 6 checks passed
@SebouChu SebouChu deleted the website-data-and-about-in-contents branch September 18, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting theme (olivialex approval) Label retirable UNIQUEMENT par Alex ou Olivia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exporter les blocs de footer

4 participants