Remplacer la balise button des lightbox des images
#1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisben
requested review from
Olivia206,
SebouChu,
arnaudlevy and
pabois
as code owners
alexisben
merged commit 9ff2367
into
adjustment/items-harmonization
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
L'usage de la balise
buttonentraîne un effet de bord sur les navigateurs qui casse le chargement progressif (loading=lazy).Le problème :
Toutes les images sont chargées alors qu'elles possèdent bien les attributs
loading=lazywidthetheight. Cela est dû à l'usage de la balisebuttonqui englobe l'image (recommandation audit RGAA Temesis). Le navigateur n'interprète plus la hauteur naturelle de l'image et stack les images les une en dessous des autres. L'intersection observer du navigateur croit alors que toutes les images sont dans le viewport et lance les chargements.La solution :
On remplace la balise
buttonpar une balisedivavec unrole=button.Niveau d'incidence
Vérifier les style s'appliquant sur le sélecteur :
figure button.