[A11Y] Retrait des <br> dans les crédits et les transcriptions#582
Merged
[A11Y] Retrait des <br> dans les crédits et les transcriptions#582
Conversation
Olivia206
added
Incidence faible 😌
Olivia206
requested review from
Clararigaud,
Marionjlss,
SebouChu,
alexisben,
arnaudlevy and
pabois
as code owners
38 tasks
Clararigaud
reviewed
Aug 26, 2024
Contributor
Clararigaud
left a comment
Clararigaud
left a comment
There was a problem hiding this comment.
All good, parcontre ca m'a permis de voir que dans les block cta, seul le premier < a > a un style button >
c'est une histoire de firstchild, je sais pas si tu veux en profiter pour fix ici ou si je fais une issue ?
Contributor
Author
|
@Clararigaud c'est volontaire ça, seul le premier élément ressemble à un bouton, les autres à des liens Si c'est bien de ça dont tu parles, le figma donne ça : |
Contributor
|
Ah d'accord pardon j'avais pas vu lre figma, j'ai juste trouvé bizarre :) |
Contributor
Author
|
Haha oups faut le dire à Arnaud ça |
Contributor
Author
|
@Clararigaud @arnaudlevy j'attends que la PR des résumés soit prête pour merge ça ? Comme ça on envoie l'admin (qaui gère les 2) dans la foulée ? |
2 tasks
Contributor
|
@SebouChu on peut valider cette osunyorg/admin#2149 ? |
Clararigaud
approved these changes
Oct 10, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Suite côté thème de la PR #2149
Niveau d'incidence
Référence (ticket et/ou figma)
#570