Skip to content

Block/video #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexisben merged 8 commits into from
Jul 25, 2022
Merged

Block/video #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1406a9b
add aspect-ratio mixin
sebousan Jul 25, 2022
7093c05
add transcrition file
sebousan Jul 25, 2022
ad1f11d
without aside
sebousan Jul 25, 2022
c34146f
Merge branch 'main' into Block/video
sebousan Jul 25, 2022
efddcbf
Merge branch 'main' into Block/video
sebousan Jul 25, 2022
bb48cd6
move transciption
sebousan Jul 25, 2022
718cdb6
transcription margin
sebousan Jul 25, 2022
98ad303
rename third argument to $selector
sebousan Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions assets/sass/_theme/_utils.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,24 @@
top: 0
z-index: $zindex-stretched-link

@mixin aspect-ratio($width, $height, $selector: 'iframe')
#{$selector}
aspect-ratio: #{$width}/#{$height}
display: block
width: 100%
@supports not (aspect-ratio: 1)
position: relative
&::before
content: ''
padding-top: ($height / $width) * 100%
width: 100%
#{$selector}
bottom: 0
left: 0
position: absolute
right: 0
top: 0

@mixin button-reset
appearance: none
background: transparent
Expand Down
46 changes: 11 additions & 35 deletions assets/sass/_theme/blocks/video.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,13 @@
// .block-video
// iframe
// aspect-ratio: 16/9
// display: block
// width: 100%
/* TODO : https://developer.mozilla.org/fr/docs/Web/HTML/Element/details */

// @supports not (aspect-ratio: 16/9)
// .video
// position: relative
// &::before
// content: ''
// display: block
// padding-top: 56.25%
// iframe
// bottom: 0
// height: 100%
// left: 0
// position: absolute
// top: 0
// width: 100%
.block-video
.video
@include aspect-ratio(16, 9, 'iframe')
.transcription
margin-top: $spacing1

// @include media-breakpoint-down(md)
// .container
// padding-left: 0
// padding-right: 0
// .transcription
// padding-left: $grid-gutter-width
// padding-right: $grid-gutter-width

// @include media-breakpoint-up(md)
// @include in-page-without-aside
// .block-content
// @include make-row()
// > *
// @include make-col-ready()
// @include make-col(8)
// @include make-col-offset(2)
@include media-breakpoint-up(md)
@include in-page-without-aside
.block-content
margin-left: col(2)
width: col(8)
2 changes: 1 addition & 1 deletion assets/sass/_theme/design-system/a11y.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
@include button-reset
&::after
font-size: px2rem(5)
line-height: px2rem(22)
line-height: px2rem(22)
2 changes: 2 additions & 0 deletions assets/sass/_theme/design-system/transcription.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.transcription
margin-top: $spacing1