Merged
Conversation
The former contains default values for where the log file is stored the ladder contains a setup_logger() function to initialize the logger and hook into the packaging/distutils2 logger.
pip2 now also logs exceptions with tracebacks CLI TESTS NEED TO BE UPDATED
Added file: tests\log.py Wraps around the pip2 logger and adds another handler so tests can capture CLI output using StringIO.
Member
|
Merged. You asked me to verify the log file location on a Mac and I did; it appears in ~/.pip2/pip2.log as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #55
Added a standard logger to pip2. The logger is located in APPDATA for Windows and in the user's home directory for Mac and Linux.
Added files:
Has default config parameters for pip2.
Sets up the pip2 logger
Adds onto the pip2 logger so that tests can be easily ran using logged output instead of sys.stdout.