Add S3 support to check-access, basic test infra #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Unit tests need to be updated to parse via the new parsing library, and I have a WIP branch for that. Ignore for now. |
cacama-valvata
approved these changes
Dec 6, 2024
cacama-valvata
left a comment
cacama-valvata
left a comment
There was a problem hiding this comment.
looks great and also thanks for testing documentation in tests/README.md, looks like tests are failing though
Signed-off-by: Robert Detjens <github@detjens.dev>
Spins up a local minikube cluster and registry and S3/minio containers. Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploads a small test file to the S3 bucket, then tries to download it as an anonymous user.
Also includes some basic test infrastructure to test against, and fixes
categoryfield not being populated correctly when parsing challenge config.Resolves #12.