backward-compatibly rename coq items to rocq#133
Open
SergioBenitez wants to merge 16 commits intoott-lang:masterfrom
Open
backward-compatibly rename coq items to rocq#133SergioBenitez wants to merge 16 commits intoott-lang:masterfrom
SergioBenitez wants to merge 16 commits intoott-lang:masterfrom
Conversation
Co-authored-by: Joey Eremondi <joey.eremondi@gmail.com>
This fixes issues with subrules in the Menhir backend by: 1. Adding a syntaxdefn field to pp_menhir_opts in types.ml 2. Modifying suppress_rule to check if a nonterminal is non-maximal in the subrule hierarchy in lex_menhir_pp.ml 3. Adding a skip_subrule_validation parameter to check_and_disambiguate in grammar_typecheck.ml 4. Passing the appropriate flag when generating Menhir output in main.ml The Menhir backend should 'only take the maximal elements from the subrule order' as documented in the comments. This implementation correctly suppresses non-maximal elements to ensure the generated parser works properly with subrules.
SergioBenitez
force-pushed
the
rocq-naming
branch
from
bfb581b to
f18b97b
Compare
This commit introduces new homs, CLI flags, and syntax, one for each of the existing Coq versions, with 'rocq' replacing 'coq' in the name. The 'coq' variants remain usable, forwarding to the now canoncial rocq variants. This is a non-breaking change.
SergioBenitez
force-pushed
the
rocq-naming
branch
from
f18b97b to
bbc1b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theoretically closes #130. Builds on #132, which builds on #131 - only the last commit is directly relevant to this PR. I've chosen
rocqinstead ofroq, but choosing the latter is a simples/rocq/roq. Please let me know if the approach in this PR is acceptable and what additional polish you'd like.