Closed
Conversation
| <ul class="media-list{{getListType()}}"> | ||
| <!-- Items of the list --> | ||
| <li class="media" ng-repeat="_item in items | filter:searchText" checkbox-group> | ||
| <li class="media" ng-repeat="_item in items | filter:searchText track by $index" checkbox-group> |
Contributor
There was a problem hiding this comment.
track by $index is what it does by default, that doesn't gain us any speed improvements.
if we have an internal id for the element let's use that track by ID for example
Contributor
|
@CyberCookie this has a lot of bugs, do you want to take another crack at it? |
Contributor
Author
|
all ng-repeats are tracking by uniq key
Angular doesn't track repeater's items by $index by default, it just create $index for each iterable item |
drKnoxy
added a commit
that referenced
this pull request
May 19, 2016
+ use track by more + use bind once in easy scenarios
Contributor
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added track by $index to repeaters with possible item count > 20