Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adjusts the ModelArtifact job’s pipelineScript so ModelPack artifacts are unpacked into /workspace and repacked correctly before pushing to the target OCI reference.
Changes:
- Updates the ModelPack branch of the job script to use different
kit unpackandkit packinvocations. - Makes the
kit packsource path explicit (/workspace).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [ "$FORMAT" = "ModelPack" ]; then | ||
| kit unpack -o ${PLAIN_HTTP:+--plain-http} model:latest -d /workspace | ||
| kit pack . --use-model-pack -t "$OCI_TARGET" | ||
| kit unpack -o model:latest -d /workspace |
There was a problem hiding this comment.
kit unpack -o model:latest -d /workspace appears to pass the image reference (model:latest) as the value for the -o flag, leaving no positional reference argument. If kit unpack expects the reference as a positional arg (as most CLIs do), this will fail at runtime. Please confirm the kitops v1.11.0 syntax and adjust (e.g., make model:latest the positional ref and use -d/-o only for the destination flag).
| kit unpack -o model:latest -d /workspace | |
| kit unpack model:latest -d /workspace |
| if [ "$FORMAT" = "ModelPack" ]; then | ||
| kit unpack -o ${PLAIN_HTTP:+--plain-http} model:latest -d /workspace | ||
| kit pack . --use-model-pack -t "$OCI_TARGET" | ||
| kit unpack -o model:latest -d /workspace | ||
| kit pack /workspace --use-model-pack -t "$OCI_TARGET" |
There was a problem hiding this comment.
The behavior for the ModelPack path is implemented via an inline shell script, but the unit tests for this package currently don’t assert the script content at all. Since this PR changes the exact kit unpack/kit pack commands, consider adding a small test that validates the generated Job’s Args[0] (pipeline script) contains the expected ModelPack commands to prevent regressions.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue in the job script's handling of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The kit unpack command was updated to remove the conditional --plain-http flag, simplifying its invocation. Additionally, the kit pack command was modified to explicitly target the /workspace directory instead of the current directory, standardizing the packing process.
No description provided.