feat: propagate model service annotations to pod template metadata#55
feat: propagate model service annotations to pod template metadata#55
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies internal/modelservice/deployment.go to propagate annotations from the ModelService to the Pod template. Feedback highlights that copying all annotations, including system-managed ones like kubectl.kubernetes.io/last-applied-configuration, can trigger unnecessary rolling updates for heavy LLM serving pods. It is recommended to filter out system annotations or provide a dedicated field for pod-level annotations to prevent unintended rollouts.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR updates the ModelService serving Deployment builder to propagate ModelService-level annotations down to the PodTemplate metadata, enabling pod-level consumers (e.g., scrapers/injectors) to rely on those annotations.
Changes:
- Add
ms.AnnotationstoDeployment.Spec.Template.ObjectMeta.AnnotationsinBuildDeployment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.