chore(deps): bump otterscale/api to v1.0.0 and k8s dependencies to v0…#47
chore(deps): bump otterscale/api to v1.0.0 and k8s dependencies to v0…#47
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the github.com/otterscale/api dependency to v1.0.0 and bumps several Kubernetes libraries to v0.35.3. Feedback was provided regarding the inconsistency of Kubernetes dependency versions, noting that while some packages were updated, others like k8s.io/apiserver remain at v0.35.0. It is recommended to align all k8s.io/* dependencies to the same version to ensure consistency and prevent potential compatibility issues.
| k8s.io/api v0.35.3 | ||
| k8s.io/apimachinery v0.35.3 | ||
| k8s.io/client-go v0.35.3 |
There was a problem hiding this comment.
The pull request title indicates a bump of Kubernetes dependencies to v0.35.3, but only k8s.io/api, k8s.io/apimachinery, and k8s.io/client-go are updated in the direct dependencies. Other Kubernetes-related packages in the indirect section (such as k8s.io/apiextensions-apiserver, k8s.io/apiserver, and k8s.io/component-base) remain at v0.35.0. To maintain consistency and avoid potential compatibility issues, all k8s.io/* dependencies should be aligned to the same version. Please run go mod tidy or manually update the remaining packages.
There was a problem hiding this comment.
Pull request overview
This PR updates the Go module dependencies for the workload-operator, bumping the OtterScale API module to its v1.0.0 release and updating core Kubernetes client libraries to the next patch release.
Changes:
- Bump
github.com/otterscale/apifromv0.9.1tov1.0.0. - Bump
k8s.io/api,k8s.io/apimachinery, andk8s.io/client-gofromv0.35.2tov0.35.3. - Refresh
go.sumto match the updated module versions/checksums.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates direct dependency versions for OtterScale API and Kubernetes libraries. |
| go.sum | Updates checksums to reflect the bumped module versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
….35.3