Skip to content

add optional options parameter for duckdb >= 1.5.0#69

Merged
gutzbenj merged 2 commits intofix/duckdb-1-5-0from
copilot/sub-pr-68
Mar 18, 2026
Merged

add optional options parameter for duckdb >= 1.5.0#69
gutzbenj merged 2 commits intofix/duckdb-1-5-0from
copilot/sub-pr-68

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

Description

duckdb_databases() in DuckDB >= 1.5.0 returns an extra options column, causing DatabaseProvider.__init__() to raise TypeError: unexpected keyword argument 'options' in identify_database_provider.

  • src/koality/models.py: Added optional options field to DatabaseProvider to absorb the extra column without error.
  • CHANGELOG.md: Added entry under [Unreleased] documenting the fix.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (please describe):

Related Issues

Checklist

  • I have read the Contributing Guidelines
  • My code follows the project's code style (poe lint passes)
  • I have added tests for my changes
  • All tests pass (poe test)
  • I have updated documentation as needed

Additional Notes

Affects any environment running DuckDB >= 1.5.0. The fix is backward-compatible — options defaults to None and is otherwise unused.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: gutzbenj <29654631+gutzbenj@users.noreply.github.com>
@gutzbenj gutzbenj marked this pull request as ready for review March 18, 2026 15:03
@gutzbenj gutzbenj merged commit b8d909f into fix/duckdb-1-5-0 Mar 18, 2026
@gutzbenj gutzbenj deleted the copilot/sub-pr-68 branch March 18, 2026 15:03
Copilot AI restored the copilot/sub-pr-68 branch March 18, 2026 15:03
Copilot AI changed the title [WIP] Add optional options parameter for duckdb >= 1.5.0 add optional options parameter for duckdb >= 1.5.0 Mar 18, 2026
Copilot AI requested a review from gutzbenj March 18, 2026 15:04
Copilot stopped work on behalf of gutzbenj due to an error March 18, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants