-
Notifications
You must be signed in to change notification settings - Fork 431
Create docker-compose.yml #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ScottBrenner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest updating https://github.com/ottomated/CrewLink-server#docker-quickstart to use Docker Compose
docker-compose.yml
Outdated
| @@ -0,0 +1,15 @@ | |||
| version: "3.6" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| version: "3.6" | |
| version: "3.8" |
https://docs.docker.com/compose/compose-file/#compose-and-docker-compatibility-matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that change doesn't work for me (Debian stable) :
ERROR: Version in "./docker-compose.yml" is unsupported. You might be seeing this error because you're using the wrong Compose file version. Either specify a supported version (e.g "2.2" or "3.3") and place your service definitions under the `services` key, or omit the `version` key and place your service definitions at the root of the file to use version 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting should be fine to ensure compatibility. I don't think this compose file uses anything specific to 3.8
Co-authored-by: Scott Brenner <scott@scottbrenner.me>
|
Readme was edited ! |
|
Nice work. Can you add port 443 (as a comment) to the exposed ports? This makes it easier for the people who want to use HTTPS. |
Oh, I thought HTTPS was listening on 9736 too ! |
|
Great work, used this as a guide for hosting my own instance :) |
I thought a docker-compose file would be useful because daemon services usually are preferred for server installs :)